Skip to content

Enable all supported encoding compressions in curl. #8437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofTheo merged 1 commit into from
Apr 23, 2025
Merged

Enable all supported encoding compressions in curl. #8437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions libs/openFrameworks/utils/ofURLFileLoader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,14 +339,34 @@ ofHttpResponse ofURLFileLoaderImpl::handleRequest(const ofHttpRequest & request)
if (request.contentType != "") {
headers = curl_slist_append(headers, ("Content-Type: " + request.contentType).c_str());
}
if(request.close)
if(request.close) {
headers = curl_slist_append(headers, "Connection: close");
if(version->features & CURL_VERSION_BROTLI) {
headers = curl_slist_append(headers, "Accept-Encoding: br");
}
if(version->features & CURL_VERSION_LIBZ) {
headers = curl_slist_append(headers, "Accept-Encoding: gzip");
}
// https://curl.se/libcurl/c/CURLOPT_ACCEPT_ENCODING.html
// the following is used for requesting specific compression encodings
// if the headers are set with the encodings, then curl will not decompress the received data
// leaving this here for future reference
// std::string encodings = "Accept-Encoding: ";
// bool first = true;
//
// if (version->features & CURL_VERSION_BROTLI) {
// encodings += "br";
// first = false;
// }
// if (version->features & CURL_VERSION_LIBZ) {
// if (!first) {encodings += ", ";}
// encodings += "gzip";
// first = false;
// }
// if( !first) {
// ofLogVerbose("ofURLFileLoader :: encodings") << encodings;
// headers = curl_slist_append(headers, encodings.c_str());
// } else {
// curl_easy_setopt(curl.get(), CURLOPT_ACCEPT_ENCODING, "");
// }
/* enable all supported built-in compressions */
curl_easy_setopt(curl.get(), CURLOPT_ACCEPT_ENCODING, "");

for (map<string, string>::const_iterator it = request.headers.cbegin(); it != request.headers.cend(); it++) {
headers = curl_slist_append(headers, (it->first + ": " + it->second).c_str());
}
Expand Down
Loading