Skip to content

fix(random_distributions): enforce real for expon lambda #8444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofTheo merged 1 commit into from
May 6, 2025
+2 −4
Merged

fix(random_distributions): enforce real for expon lambda #8444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions examples/math/randomExample/src/ofApp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,10 @@ void ofApp::perform() {
ofLogNotice("gaussian aka normal<vec3>(10,2)") << gaussian<vec3>(10, 2);
ofLogNotice("gaussian aka normal<vec3>({10,20,30},{2,1,.5})") << gaussian<vec3>({ 10, 20, 30 }, { 2, 1, .5 });

// exponential requires 1 args (no defaults)
// exponential requires 1 args (no defaults) which must be real (not int)

ofLogNotice("exponential(2.5)") << of::random::exponential(2.5);
ofLogNotice("exponential<double>(2.5)") << exponential<double>(2.5);
ofLogNotice("exponential<int>(2.5)") << exponential<int>(2.5);
ofLogNotice("exponential<vec2>(2.5)") << exponential<vec2>(2.5);
ofLogNotice("exponential<vec4>(2.5)") << exponential<vec4>(2.5);
ofLogNotice("exponential<vec2>({2.5, 10})") << exponential<vec2>({ 2.5, 10 });
Expand All @@ -145,7 +144,6 @@ void ofApp::perform() {

ofLogNotice("ofRandomExponential(2.5)") << ofRandomExponential(2.5);
ofLogNotice("ofRandomExponential<double>(2.5)") << ofRandomExponential<double>(2.5);
ofLogNotice("ofRandomExponential<int>(2.5)") << ofRandomExponential<int>(2.5);
ofLogNotice("ofRandomExponential<vec2>(2.5)") << ofRandomExponential<vec2>(2.5);
ofLogNotice("ofRandomExponential<vec2>({2.5, 10})") << ofRandomExponential<vec2>({ 2.5, 10 });
ofLogNotice("ofRandomExponential<vec3>(2.5, 10, 0.1") << ofRandomExponential<vec3>(2.5);
Expand Down
2 changes: 1 addition & 1 deletion libs/openFrameworks/utils/ofRandomDistributions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ poisson(T mean, G & g = of::random::gen()) {
/// \param g the random engine (default: OF internal of::random::gen())
/// \return an exponential random value ot type T
template <typename T = float, typename G = decltype(of::random::gen()), typename = std::enable_if_t<is_random_engine_v<G>>>
std::enable_if_t<std::is_arithmetic_v<T>, T>
std::enable_if_t<std::is_floating_point_v<T>, T>
exponential(T lambda, G & g = of::random::gen()) {
return std::exponential_distribution<T>{lambda}(g);
}
Expand Down
Loading