Skip to content

🔒️(backend) use constant-time comparison for signature #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanreveille merged 1 commit into from
Jan 12, 2026
+4 −1
Merged

🔒️(backend) use constant-time comparison for signature #2712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/richie/apps/courses/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
API endpoints for the courses app.
"""

import hmac

from django.conf import settings
from django.core.cache import caches
from django.db.models import Q
Expand Down Expand Up @@ -253,8 +255,9 @@ def sync_course_runs_from_request(request, version):
if not authorization_header:
return Response("Missing authentication.", status=403)

# Use `hmac.compare_digest` to prevent time attacks
signature_is_valid = any(
authorization_header == get_signature(message, secret)
hmac.compare_digest(authorization_header, get_signature(message, secret))
for secret in getattr(settings, "RICHIE_COURSE_RUN_SYNC_SECRETS", [])
)

Expand Down