Project localization/translation support #6645
Open
+42
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for d8f269b: arm64-android |
|
Since we do expose and rely on project titles and other layer metadata quite a lot in our UI, this was a very good reason to improve project translation upstream and add support for the localization of basic project and layer metadata. The result is here: qgis/QGIS#63168 🥳 |
mohsenD98
reviewed
Sep 17, 2025
Comment on lines
+280
to
+304
| else if ( suffix == QStringLiteral( "qgs" ) || suffix == QStringLiteral( "qgz" ) ) | ||
| { | ||
| QRegularExpression re( QStringLiteral( "(.*)_[A-Za-z]{2}" ) ); | ||
| QRegularExpressionMatch match = re.match( fi.completeBaseName() ); | ||
| if ( match.hasMatch() ) | ||
| { | ||
| if ( items.contains( QStringLiteral( "%1.qgs" ).arg( match.captured( 1 ) ), Qt::CaseInsensitive ) || items.contains( QStringLiteral( "%1.qgz" ).arg( match.captured( 1 ) ), Qt::CaseInsensitive ) ) | ||
| { | ||
| // Skip translated project, users should always use the original project | ||
| continue; | ||
| } | ||
| } | ||
| } | ||
| else if ( suffix == QStringLiteral( "zip" ) ) | ||
| { | ||
| if ( item.endsWith( QStringLiteral( "_attachments.zip" ), Qt::CaseInsensitive ) ) | ||
| { | ||
| const QString reducedItemName = item.mid( 0, item.size() - 16 ); | ||
| if ( items.contains( QStringLiteral( "%1.qgs" ).arg( reducedItemName ), Qt::CaseInsensitive ) || items.contains( QStringLiteral( "%1.qgz" ).arg( reducedItemName ), Qt::CaseInsensitive ) ) | ||
| { | ||
| // Skip project attachments sidecar file | ||
| continue; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
@nirvn , could you please elaborate a bit more on what the code is doing?
There was a problem hiding this comment.
@mohsenD98 , it's skipping sidecar files that QGIS generates alongside the main .qgs project file. The sidecar files are of no use and should only be accessed by opening the main project.qgs file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for localized / translated project files so that QField can speak a lot of languages too (background reading: https://www.opengis.ch/2018/09/11/qgis-speaks-a-lot-of-languages/). This also works with cloud projects, which is reallly nice.
Contrary to QGIS, we will always display a localized project if the _XX.qm file is present (i.e., we don't require users to overwrite / specify a locale). It will respect the phone / device's OS locale, or the one specified in QField settings panel.
Implements / fixes #5670