Export basemap as mbtiles during cable export#105
Merged
suricactus merged 1 commit intomasterfrom Mar 5, 2025
Merged
Conversation
gounux
commented
Feb 20, 2025
Member
Author
gounux
left a comment
gounux
left a comment
There was a problem hiding this comment.
Thoughts and reflections about the ongoing dev work made so far.
ping @suricactus
gounux
force-pushed
the
QF-4902-package-rasters-multiple-zoom-levels
branch
from
40fb529 to
20badfa
Compare
gounux
commented
Feb 25, 2025
gounux
force-pushed
the
QF-4902-package-rasters-multiple-zoom-levels
branch
from
13b5ab5 to
053ffd4
Compare
suricactus
reviewed
Mar 2, 2025
Collaborator
suricactus
left a comment
suricactus
left a comment
There was a problem hiding this comment.
Code looks good. We need to add a cancelling algorithm, as I mentioned on the QFieldSync repo.
suricactus
reviewed
Mar 4, 2025
suricactus
reviewed
Mar 4, 2025
gounux
commented
Mar 4, 2025
suricactus
reviewed
Mar 4, 2025
Collaborator
suricactus
left a comment
suricactus
left a comment
There was a problem hiding this comment.
Good job! First from many PRs in (lib)qfieldsync! Small comment about documenting the finally. Ready to merge right after addressing it!
suricactus
approved these changes
Mar 4, 2025
gounux
force-pushed
the
QF-4902-package-rasters-multiple-zoom-levels
branch
from
f715822 to
9e7dbf1
Compare
suricactus
reviewed
Mar 4, 2025
suricactus
approved these changes
Mar 4, 2025
Set max tiles zoom level export to 14 Use a cloned version of basemap layer when for independant project export Remove old tiff offline export Add comment for raster layer cloning Clone project to generate tiles based on map theme Connect native mbtiles alg progress to custom progress signal Remove unused tiff basemap generation method Add offline converter cancel logic Update libqfieldsync/offline_converter.py Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com> Add flag to store and check canceled state of the packaging Add comment for the try packaging finally clause Play it more defensive with sign disconnection
gounux
force-pushed
the
QF-4902-package-rasters-multiple-zoom-levels
branch
from
9e7dbf1 to
a7a88b5
Compare
suricactus
approved these changes
Mar 5, 2025
Collaborator
suricactus
left a comment
suricactus
left a comment
There was a problem hiding this comment.
Thanks. Huge first PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the cable export generate a
mbtilesbasemap for QField, thus enabling multiple raster zoom levels.Subtasks:
native:tilesxyzmbtilesprocessing algorithm to generate a mbtiles fileSingle layerbasemap mbtiles export during cable exportSingle layerbasemap mbtiles export during cable exportSingle layerbasemap mbtiles in QField appMap themebasemap mbtiles export during cable exportMap themebasemap mbtiles export during cable exportMap themebasemap mbtiles in QField appsee opengisch/qfieldsync#637