Support packaging of project translation files#129
Merged
suricactus merged 5 commits intomasterfrom Mar 3, 2026
Merged
Conversation
suricactus
reviewed
Sep 16, 2025
suricactus
reviewed
Sep 16, 2025
suricactus
reviewed
Sep 16, 2025
suricactus
approved these changes
Sep 16, 2025
Collaborator
There was a problem hiding this comment.
Nice functionality, +1 for the tests.
Code looks good. A few tiny comments on readability. Feel free to merge.
Do you consider this "QFieldCloud sensitive files", such as the plugins? Shall we add them here:
https://github.com/opengisch/QFieldCloud/blob/master/docker-app/qfieldcloud/filestorage/utils.py#L69
Member
Author
|
@suricactus , review addressed thanks. Regarding "sensitive files", I wouldn't flag the translations as being sensitive. If you have a strong feeling about it, we can add it into the above-mentioned function. |
suricactus
reviewed
Oct 9, 2025
suricactus
reviewed
Oct 9, 2025
suricactus
force-pushed
the
project_translation_files
branch
from
2fad9c6 to
b2048aa
Compare
suricactus
force-pushed
the
project_translation_files
branch
from
b2048aa to
891b4fc
Compare
suricactus
force-pushed
the
project_translation_files
branch
from
891b4fc to
17e5272
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unlocks translated projects on QFieldCloud by insuring that {project name}_{2-letter language code}.qm files are copied into the packaged project directory.
The PR also insures that sidecar translations and project plugin files properly adopt the exported project name (i.e. myproject.qgs -> myproject_cloud.qgs means the project plugin file will become myproject_cloud.qml and translation files would be myproject_de.qm, myproject_fr.qm, etc.).
Test coverage included.