fix: wrap coordinate transform in try/catch so we don't get random failures#139
Merged
suricactus merged 4 commits intomasterfrom Mar 4, 2026
Merged
fix: wrap coordinate transform in try/catch so we don't get random failures#139suricactus merged 4 commits intomasterfrom
suricactus merged 4 commits intomasterfrom
Conversation
…ilures If the coordinate transform of a given bbox fails, just dump all data from that layer.
suricactus
force-pushed
the
safe_transform
branch
from
6098dc4 to
1c48e64
Compare
nirvn
approved these changes
Mar 4, 2026
nirvn
reviewed
Mar 4, 2026
| Qgis, | ||
| QgsCoordinateReferenceSystem, | ||
| QgsCoordinateTransform, | ||
| QgsCsException, # type: ignore[import] |
Collaborator
Author
There was a problem hiding this comment.
you have any idea why the QgsCsException is not available in the python type definitions? But there is no problem importing it in the end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the coordinate transform of a given bbox fails, just dump all data from that layer.
We are not aware of immediate conversion failing, but better be safe than sorry.
See #138 (comment) . Ping @nirvn