Skip to content

Add common parameter names as const#42

Closed
domi4484 wants to merge 1 commit intoopengisch:mainfrom
domi4484:addConstForConfigs
Closed

Add common parameter names as const#42
domi4484 wants to merge 1 commit intoopengisch:mainfrom
domi4484:addConstForConfigs

Conversation

@domi4484
Copy link
Member

Provide handy constants for common used parameters

@3nids 3nids requested a review from gacarrillor April 17, 2025 20:20
Copy link
Member

@gacarrillor gacarrillor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @domi4484

Out of curiosity, where would you like to use these constants?

@domi4484
Copy link
Member Author

I would like to know the key names for the dict returned by service_config. At leas the most commons...

@gacarrillor
Copy link
Member

I would like to know the key names for the dict returned by service_config. At leas the most commons...

Got it, could you add that to the comment above the parameter list?
Just to let future readers know about what are they for.

BTW, a complete list can be found here, just in case you want to add the URL to the comment, but could be too much :)
https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PARAMKEYWORDS

@domi4484
Copy link
Member Author

@gacarrillor thanks for pointing me to the doc. As there are so many parameters I don't think anymore that this is a useful addition. I'll close this PR

@domi4484 domi4484 closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants