Add support for dependency check while installing a plugin#38
Merged
m-kuhn merged 2 commits intoopengisch:mainfrom Nov 10, 2025
Merged
Add support for dependency check while installing a plugin#38m-kuhn merged 2 commits intoopengisch:mainfrom
m-kuhn merged 2 commits intoopengisch:mainfrom
Conversation
Rationale: Since the installer has already loaded the original qgis.utils.loadPlugin when QPIP gets loaded, monkey patching qgis.utils.loadPlugin is not enough. We need to monkey patch also installer.loadPlugin as well.
gacarrillor
force-pushed
the
check_deps_on_plugin_install
branch
from
7d59424 to
70f35a7
Compare
…tore the active cursor when entering to the monkey patched loadPlugin, do the dependency check and enventual install, and finally restore the original active cursor when leaving.
m-kuhn
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this way, QPIP will not only check deps when a plugin is activated/loaded, but also when it's installed (either via plugin repo or via ZIP).
This avoids getting
Module Not Founderrors when a plugin is installed and calling itsclassFactory()already imports other Python deps that are not present in the system.Also, avoid waiting cursor set by QGIS for plugin installation when QPIP dialog is shown. We save the current cursor when entering the monkey patched
loadPlugin, and restore it when leaving that method.