dockerfile: fix comment regex to preserve line continuation backslash#2
Open
abezdina wants to merge 1 commit intoopengrep:opengrep/mainfrom
Open
Conversation
Change the comment regex from /#.*/ to /#[^\\\n]*(?:\\.[^\\\n]*)*/ so that a trailing backslash on a comment line is NOT consumed as part of the comment token.
abezdina
force-pushed
the
da/dockerfile-fix-crlf-and-comment-parsing
branch
from
a5babc9 to
229a184
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the comment regex in the tree-sitter Dockerfile grammar from
/#.*/to/#[^\\\n]*(?:\\.[^\\\n]*)*/so that backslashes at the end of comment lines are not consumed by the comment token.This allows LABEL continuation lines with interspersed comments to parse correctly:
Part of opengrep/opengrep#586 — fixes Dockerfile parser to correctly handle comments