Skip to content

[airq] Add Radon sensor and correct spelling mistake#20146

Open
Merlin10437 wants to merge 10 commits intoopenhab:mainfrom
Merlin10437:feature/new-sensors
Open

[airq] Add Radon sensor and correct spelling mistake#20146
Merlin10437 wants to merge 10 commits intoopenhab:mainfrom
Merlin10437:feature/new-sensors

Conversation

@Merlin10437
Copy link

This PR adds support for our radon sensor and CO was mistakenly labeled as CO2 in one place.
This improvement was not discussed on github, but our customers asked for this addition.

@lsiepel lsiepel requested a review from Copilot January 26, 2026 17:38
@jlaur jlaur changed the title [air-Q] add Radon sensor and correct spelling mistake [airq] Add Radon sensor and correct spelling mistake Jan 26, 2026
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, i left some comments to look at. I guess this needs testing due to UoM change.

And besides these suggestions, it might happen that the readme table alignment is off. Please adapt that with your favorite markdown tool.

Edit: You also might want to look into the DCO check that is failing: https://github.com/openhab/openhab-addons/pull/20146/checks?check_run_id=61491950937

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove changes to this file. Translations are maintained by crowdin.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately there seems to have been an error in the translation then, as the CO channel was labeled as CO2. That is what I intended to fix, but I can take out the change for the CO2 channel?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should be fixed in crowdin, not here on GitHub

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove changes to this file. Translations are maintained by crowdin.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, I should remove the radon addition?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be changed on GitHub, it is managed by crowdin

@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Jan 26, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for a new radon sensor channel to the air-Q binding and corrects a mislabeled CO vs CO₂ text in the German localization.

Changes:

  • Defines a new radon channel and channel-type in thing-types.xml, wires it into AirqHandler.pollData(), and documents it in the README and example items.
  • Adds i18n entries for the radon channel in English, German, and Italian property bundles.
  • Fixes the German CO/CO₂ label mix-up so that co is described as CO concentration and co2 as CO₂ concentration.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml Adds a radon channel and corresponding channel-type so the binding can expose radon measurements.
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/i18n/airq_it.properties Introduces an Italian label entry for the new radon channel.
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/i18n/airq_de.properties Corrects CO/CO₂ labels and adds a German entry for the radon channel.
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/i18n/airq.properties Adds the English label for the radon channel.
bundles/org.openhab.binding.airq/src/main/java/org/openhab/binding/airq/internal/AirqHandler.java Extends pollData() to read the radon value from the device JSON and update the new radon channel.
bundles/org.openhab.binding.airq/README.md Documents the new radon channel in the channels table and example items so users can configure it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the channels table, the channel name for radon is Radon with an initial capital, whereas all other entries are lowercase and the actual channel id defined in thing-types.xml is radon. This inconsistency can mislead users copying from the README; please change the channel column entry to radon to match the defined id and surrounding entries.

Suggested change
| Radon | Number:Dimensionless | | Radon concentration |
| radon | Number:Dimensionless | | Radon concentration |

Copilot uses AI. Check for mistakes.
@jlaur
Copy link
Contributor

jlaur commented Jan 26, 2026

Please also add update instructions so that the new channels will be added to existing Things.

Merlin10437 and others added 7 commits January 27, 2026 09:35
…ng/thing-types.xml

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Merlin <152161717+Merlin10437@users.noreply.github.com>
…ng/thing-types.xml

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Merlin <152161717+Merlin10437@users.noreply.github.com>
…ng/thing-types.xml

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Merlin <152161717+Merlin10437@users.noreply.github.com>
Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Merlin <152161717+Merlin10437@users.noreply.github.com>
Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Merlin <152161717+Merlin10437@users.noreply.github.com>
…n/airq_de.properties

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Merlin <152161717+Merlin10437@users.noreply.github.com>
…n/airq_it.properties

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Merlin <152161717+Merlin10437@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement or new feature for an existing add-on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments