[ring] Add an extended description of events#20198
Open
psmedley wants to merge 5 commits intoopenhab:mainfrom
Open
[ring] Add an extended description of events#20198psmedley wants to merge 5 commits intoopenhab:mainfrom
psmedley wants to merge 5 commits intoopenhab:mainfrom
Conversation
Signed-off-by: Paul Smedley <paul@smedley.id.au>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Ring Account “Events” channel intended to expose an extended, notification-like description that distinguishes between person/vehicle/motion.
Changes:
- Introduces a new
extendedDescriptionchannel (channel type + event group wiring) and bumps the account thing type version to2with update instructions for existing Things. - Adds API DTO support for
cv_properties(CVPropertiesTO) and wires it intoRingEventTO. - Updates
AccountHandlerto populate the new channel based oncv_properties.detection_type, and updates README with the new channel.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| bundles/org.openhab.binding.ring/src/main/resources/OH-INF/update/instructions.xml | Adds update instructions to inject the new channel for existing ring:account Things (targetVersion 2). |
| bundles/org.openhab.binding.ring/src/main/resources/OH-INF/thing/thing-types.xml | Adds thingTypeVersion=2 for the account bridge and defines the new channel + channel-type. |
| bundles/org.openhab.binding.ring/src/main/java/org/openhab/binding/ring/internal/handler/AccountHandler.java | Publishes the new extended description state based on cv_properties.detection_type. |
| bundles/org.openhab.binding.ring/src/main/java/org/openhab/binding/ring/internal/api/RingEventTO.java | Adds cv_properties field to event DTO. |
| bundles/org.openhab.binding.ring/src/main/java/org/openhab/binding/ring/internal/api/CVPropertiesTO.java | New DTO for CV properties used by the handler logic. |
| bundles/org.openhab.binding.ring/src/main/java/org/openhab/binding/ring/RingBindingConstants.java | Adds a channel constant for event#extendedDescription. |
| bundles/org.openhab.binding.ring/README.md | Documents the new channel and provides an items example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...hab.binding.ring/src/main/java/org/openhab/binding/ring/internal/handler/AccountHandler.java
Show resolved
Hide resolved
...hab.binding.ring/src/main/java/org/openhab/binding/ring/internal/handler/AccountHandler.java
Outdated
Show resolved
Hide resolved
...openhab.binding.ring/src/main/java/org/openhab/binding/ring/internal/api/CVPropertiesTO.java
Show resolved
Hide resolved
...rg.openhab.binding.ring/src/main/java/org/openhab/binding/ring/internal/api/RingEventTO.java
Show resolved
Hide resolved
…ding/ring/internal/handler/AccountHandler.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enhancement adds a new channel that provides a description of whether the motion event includes a person or a vehicle.