Skip to content

Comments

[homekit.binding] Minor tweaks#20209

Merged
jlaur merged 7 commits intoopenhab:mainfrom
andrewfg:homekit-pairing-code
Feb 13, 2026
Merged

[homekit.binding] Minor tweaks#20209
jlaur merged 7 commits intoopenhab:mainfrom
andrewfg:homekit-pairing-code

Conversation

@andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Feb 10, 2026 •
edited
Loading

I am repurposing this PR to withdraw the original permission of 11 digit codes, and instead fix two small issues:

  1. Improve the pairing code regex to enforce exactly 8 digit codes.
  2. Fix a bug in [homekit.binding] Increase maximum permitted HTTP content length #20212 which was merged too soon.

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

@andrewfg
allow 11 digit pairing codes
d642391 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg self-assigned this Feb 10, 2026
@andrewfg andrewfg added the enhancement An enhancement or new feature for an existing add-on label Feb 10, 2026
@andrewfg andrewfg requested review from a team and Copilot February 10, 2026 18:02

This comment was marked as off-topic.

Sign in to view

@andrewfg
Update bundles/org.openhab.binding.homekit/src/main/java/org/openhab/…
5398e61 
…binding/homekit/internal/handler/HomekitBaseAccessoryHandler.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg marked this pull request as draft February 10, 2026 18:17
@lsiepel
Copy link
Contributor

lsiepel commented Feb 10, 2026

spotless

@andrewfg
spotless
0dce31e 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg marked this pull request as ready for review February 10, 2026 19:51
@jlaur

This comment was marked as off-topic.

Sign in to view
@jlaur

This comment was marked as off-topic.

Sign in to view
@andrewfg
update readme
376fb94 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg

This comment was marked as off-topic.

Sign in to view
@andrewfg andrewfg marked this pull request as draft February 11, 2026 11:30
@jlaur

This comment was marked as off-topic.

Sign in to view
@andrewfg
Copy link
Contributor Author

andrewfg commented Feb 11, 2026

supporting 11 digit pairing codes in this binding would be useless and misleading

Understood. I will revert the 11 digit code. However I will keep this PR for a very small improvement in the Regex to ensure nothing more than 8 digits.

@andrewfg
revert 11 digit codes; retain regex anchors
ccc5b85 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
Merge remote-tracking branch 'upstream/main' into homekit-pairing-code
1247449
@andrewfg
fix error in openhab#20212
674c7e4 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg changed the title [binding.homekit] Permit 11 digit pairing codes [binding.homekit] Minor tweaks Feb 11, 2026
@andrewfg andrewfg marked this pull request as ready for review February 11, 2026 11:50
@andrewfg andrewfg requested review from jlaur and removed request for a team February 11, 2026 11:50
@andrewfg andrewfg mentioned this pull request Feb 11, 2026
Merged
@andrewfg andrewfg requested a review from Copilot February 11, 2026 12:25

This comment was marked as resolved.

Sign in to view

jlaur
jlaur approved these changes Feb 13, 2026
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit 16345d1 into openhab:main Feb 13, 2026
7 of 8 checks passed
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on and removed enhancement An enhancement or new feature for an existing add-on labels Feb 13, 2026
@jlaur jlaur added this to the 5.2 milestone Feb 13, 2026
@andrewfg andrewfg changed the title [binding.homekit] Minor tweaks [homekit.binding] Minor tweaks Feb 14, 2026
@andrewfg andrewfg deleted the homekit-pairing-code branch February 15, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jlaur jlaur jlaur approved these changes

Assignees

@andrewfg andrewfg

Labels

bug An unexpected problem or unintended behavior of an add-on

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewfg @lsiepel @jlaur