[hue] Fix discovery of API v2 unknown archetype devices#20388
[hue] Fix discovery of API v2 unknown archetype devices#20388lsiepel merged 3 commits intoopenhab:mainfrom
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
There was a problem hiding this comment.
Pull request overview
Fixes Hue CLIP v2 discovery regression where devices reporting unknown_archetype were being skipped, restoring discovery for switches/buttons/sensors that no longer provide a specific archetype in firmware updates.
Changes:
- Stop ignoring
UNKNOWN_ARCHETYPEduring discovery by adjusting the archetype ignore set. - Switch discovery’s “ignore bridge devices” check to use
product_data.product_archetypeinstead ofmetadata.archetype. - Minor adjustment to how discovery labels are selected (preferring metadata name).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.../discovery/Clip2ThingDiscoveryService.java |
Updates discovery filtering to no longer skip unknown archetype devices and adjusts label selection logic. |
.../dto/clip2/enums/Archetype.java |
Removes UNKNOWN_ARCHETYPE from the set of archetypes excluded from discovery. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
...hue/src/main/java/org/openhab/binding/hue/internal/discovery/Clip2ThingDiscoveryService.java
Outdated
Show resolved
Hide resolved
...inding.hue/src/main/java/org/openhab/binding/hue/internal/api/dto/clip2/enums/Archetype.java
Outdated
Show resolved
Hide resolved
...hue/src/main/java/org/openhab/binding/hue/internal/discovery/Clip2ThingDiscoveryService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
I think it's this one: #19838? Before that, only |
Resolves #20387
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch
edit: regression of: #19838