[ahawastecollection] Fix upgrade instructions

[lsiepel]

Somehow this wrong tag was not discovered during tests and review.

Fixes: #20383

Should be backported as it is part of 5.1.3 and the current binding is unusable

[Copilot]

Pull request overview

Fixes the AHA Waste Collection binding’s upgrade instructions by correcting the XML element used to specify channel types in update.xml, addressing the unusable binding state reported in issue #20383.

Changes:

• Replace <typeId> with <type> for add-channel instructions in target versions 1 and 2.
• Ensure the upgrade instructions reference the correct channel type identifiers during migration.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[lsiepel]

@andrewfg do you have any thoughts about wether we should add a validation for upgrade instructions similar to the thing-type ?

[andrewfg]

thoughts about whether we should add a validation

All of thing-type, update-description, config-description, and addon are schema validated passively via the Eclipse or Visual Studio Code IDEs. But only thing-type get actively validated during the CI build. And indeed I think that thing-type only gets partially validated since if it imports a config-description then I think that part is not validated. So the current approach is certainly very inconsistent. Personally I would favour applying schema validation to all. (But I am sure other will have other opinions)

[lsiepel]

Thanks, I don't see this validation/check in vscode. I would opt to add it as build gatekeepere, to prevent issues like this. I might create a PR to do the validation similar to the thing-type.xml

[andrewfg]

don't see this validation/check in vscode

I think you need an xml plugin

[jlaur]

Regression of #19834 and #19833. @lsiepel - cannot be backported unless you separate into two PR's.

[lsiepel]

This is now a fix for the regression of #19833 and should be backported

[jlaur]

Thanks!