Allow rule with no trigger in DSL Rule file format#5462
Open
lolodomo wants to merge 2 commits intoopenhab:mainfrom
Open
Allow rule with no trigger in DSL Rule file format#5462lolodomo wants to merge 2 commits intoopenhab:mainfrom
lolodomo wants to merge 2 commits intoopenhab:mainfrom
Conversation
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Contributor
|
This is requested by #3655. If there are no triggers, then |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the openHAB DSL rules grammar to allow rule declarations whose when section contains no triggers, and adds integration tests to validate that such rules are loaded with an empty trigger list.
Changes:
- Make the
EventTriggerlist in thewhenclause optional inRules.xtext. - Extend existing rule-loading assertions to check trigger/action list sizes.
- Add an integration test covering a rule with no triggers (
whenimmediately followed bythen).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| itests/org.openhab.core.model.rule.tests/src/main/java/org/openhab/core/model/rule/runtime/DSLRuleProviderTest.java | Adds coverage for “no trigger” DSL rules and strengthens assertions for trigger/action list sizes. |
| bundles/org.openhab.core.model.rule/src/org/openhab/core/model/rule/Rules.xtext | Updates Xtext grammar so when can contain zero triggers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
....model.rule.tests/src/main/java/org/openhab/core/model/rule/runtime/DSLRuleProviderTest.java
Outdated
Show resolved
Hide resolved
… parameter It was already called with StandardCharsets.UTF_8 for certain tests in that test class. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.