Refactor DSLRuleProvider change notification#5465
Draft
Nadahar wants to merge 1 commit intoopenhab:mainfrom
Draft
Refactor DSLRuleProvider change notification#5465Nadahar wants to merge 1 commit intoopenhab:mainfrom
Nadahar wants to merge 1 commit intoopenhab:mainfrom
Conversation
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a result of the discussion here #3725 (comment), I started trying to find a way to solve the notification handling.
This is my suggested approach, I had already come quite far before our discussion, so I decided to complete it. I haven't tested it, I want to discuss it before putting any more work into it.
@lolodomo What do you think of the approach? #5449 could either include this commit, or it could be merged before #5449, it doesn't really matter, but I think it should be relatively easy to do the changes needed in #5449 on top of this?
By the way, I decided to exclude isolated rules from the
xExpressionsmap, because it seems that map is used as a lookup when rules are run byRuleEngine. Isolated rules should never actually be run, so I see it as simpler to exclude them from the map.