Handle log-viewer heartbeat #3576
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to illustrate some of what I suggested in #3569. I don't consider it complete, both because I'm not sure if what I did in
ws.tsis correct/complete (no close callback implemented events, for example) and because I'm not sure if the visual solution is ideal.I haven't attempted to make any reconnect timer mechanism either. But, it does seem to function. As a plus, it turns out that it also solves a problem I didn't know existed: The "heartbeat timer" is never stopped if the remote closes the connection. With this PR it does, so it doesn't keep trying to send the heartbeat over and over again after the socket is closed.