Skip to content

Conversation

@Nadahar
Copy link
Contributor

@Nadahar Nadahar commented Dec 12, 2025

This is meant to illustrate some of what I suggested in #3569. I don't consider it complete, both because I'm not sure if what I did in ws.ts is correct/complete (no close callback implemented events, for example) and because I'm not sure if the visual solution is ideal.

I haven't attempted to make any reconnect timer mechanism either. But, it does seem to function. As a plus, it turns out that it also solves a problem I didn't know existed: The "heartbeat timer" is never stopped if the remote closes the connection. With this PR it does, so it doesn't keep trying to send the heartbeat over and over again after the socket is closed.

@relativeci
Copy link

relativeci bot commented Dec 12, 2025

#4082 Bundle Size — 12.54MiB (~+0.01%).

9342247(current) vs 005e8c7 main#4081(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#4082
     Baseline
#4081
Regression  Initial JS 1.52MiB(~+0.01%) 1.52MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 7.06% 7.05%
No change  Chunks 620 620
No change  Assets 702 702
No change  Modules 2437 2437
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 130 130
No change  Duplicate Packages 1 1
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#4082
     Baseline
#4081
Regression  JS 10.87MiB (~+0.01%) 10.87MiB
Regression  CSS 846.54KiB (+0.03%) 846.25KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 45.73KiB 45.73KiB
No change  Other 847B 847B

Bundle analysis reportBranch Nadahar:log-viewerProject dashboard


Generated by RelativeCIDocumentationReport issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request main ui Main UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants