Update widget-mixin to composable #3862
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#4601 Bundle Size — 12.85MiB (+0.23%).e320191(current) vs 9682acd main#4599(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #4601 |
Baseline #4599 |
|
|---|---|---|
 Initial JS |
3.23MiB(+104.18%) |
1.58MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
8.47% |
6.65% |
| Chunks |
592(-1.66%) |
602 |
| Assets |
669(-2.48%) |
686 |
| Modules |
2598(+0.15%) |
2594 |
| Duplicate Modules |
0 |
0 |
| Duplicate Code |
0% |
0% |
| Packages |
123 |
123 |
| Duplicate Packages |
1 |
1 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #4601 |
Baseline #4599 |
|
|---|---|---|
| JS |
11.13MiB (+0.27%) |
11.1MiB |
| CSS |
895.03KiB (-0.02%) |
895.16KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
45.73KiB |
45.73KiB |
| Other |
847B |
847B |
Bundle analysis report Branch jsjames:use-widget-context Project dashboard
Generated by RelativeCI Documentation Report issue
jsjames
force-pushed
the
use-widget-context
branch
5 times, most recently
from
14cb976 to
41aea78
Compare
jsjames
added
main ui
jsjames
commented
Feb 8, 2026
| function childContext(component: UiComponent): WidgetContext { | ||
| return { | ||
| component, | ||
| // rootcomponent: context?.root || context?.component, |
Contributor
Author
There was a problem hiding this comment.
@florian-h05 - I don't see anywhere that rootcomponent is used? Is this legacy and can we remove?
jsjames
commented
Feb 8, 2026
| if (context?.component.slots) Object.assign(widget.slots, context.component.slots) | ||
| const widgetContext = { | ||
| component: widget, | ||
| // root: widget, |
Contributor
Author
There was a problem hiding this comment.
@florian-h05 same here, i don't see where root is used.
jsjames
force-pushed
the
use-widget-context
branch
from
41aea78 to
2dc7d1d
Compare
Signed-off-by: Jeff James <[email protected]> (+1 squashed commit) Squashed commits: [1ee38f0dc] Updated performance (+2 squashed commits) Squashed commits: [f3ea89d7a] Performance metrics [3e02a0f3c] WIP (+5 squashed commits) Squashed commits: [f07c59d] WIP [20ffc61] WIP [1638608] WIP [b42cfd0] WIP [7feb909] WIP (+3 squashed commits) Squashed commits: [63a4a18] working [408705a] WIP [7be6336] WIP Signed-off-by: Jeff James <[email protected]>
jsjames
force-pushed
the
use-widget-context
branch
from
8373734 to
5d14a3f
Compare
Signed-off-by: Jeff James <[email protected]>
Signed-off-by: Jeff James <[email protected]>
jsjames
force-pushed
the
use-widget-context
branch
from
bfda55f to
e320191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the widget-mixin to a composable - as a step necessary to use composition api with widget components.
In composition API, components must be registered globally if referenced by name - hence all widgets are registered globally. Note, there is no performance impact here.
Cleanup of importing components in each of the widgets will happen in later PR now that they are globally registered.
Adds typescript definitions for widget definitions
Removed special title overflow in oh-list-item for divider as css text-overflow does the same operation and is now part of the f7 styles.