Feature/coloreddashboard - Added ability to configure background colors for dashboard tiles/cards.#295
Conversation
Signed-off-by: Lucky Mallari <luckymallari@gmail.todotcom>
Fixes openhab#294 Signed-off-by: Lucky Mallari <luckymallari@gmail.todotcom>
ghys
left a comment
ghys
left a comment
There was a problem hiding this comment.
Looks good, left a few comments.
Also the docs need to be updated (https://docs.openhab.org/configuration/habpanel.html#the-main-menu) ;)
| <input name="name" type="text" ng-model="form.tile.background_image" class="form-control" /> | ||
| <select name="background_type" ng-model="form.tile.background_type" class="form-control"> | ||
| <option value="default" translate-keep-content translate="dashboard.settings.tile.background.type.default">Default</option> | ||
| <option value="url" translate-keep-content translate="dashboard.settings.tile.background.type.url">URL</option> |
There was a problem hiding this comment.
I think "URL" could be left untranslated? :)
| <select name="background_type" ng-model="form.tile.background_type" class="form-control"> | ||
| <option value="default" translate-keep-content translate="dashboard.settings.tile.background.type.default">Default</option> | ||
| <option value="url" translate-keep-content translate="dashboard.settings.tile.background.type.url">URL</option> | ||
| <option value="color" translate-keep-content translate="dashboard.settings.tile.background.type.color">Color</option> |
There was a problem hiding this comment.
"Color" is actually one the "common terms" I devised and is already translated in main.pot so you can simply use
the "translate" directive without any further indication :)
| msgid "Default" | ||
| msgstr "" | ||
|
|
||
| #. Background Option URL Text |
| msgid "URL" | ||
| msgstr "" | ||
|
|
||
| #. Background Option Color Text |
| msgid "Background Type" | ||
| msgstr "" | ||
|
|
||
| #. Background Option Default Text |
There was a problem hiding this comment.
Maybe "default" could be added as a "common term" as well actually! I'll have a look
|
Also need it for widgets, we need some way to show that many widgets are the part of the same thing. Without borders looks frustrating |
|
@ghys @kaikreuzer any change to get this merged? |
4 participants
Added ability to configure background colors for dashboard tiles/cards.
So now, we have the ability to add either a color or a URL.
"Default" in dropdown setting means unset, and will use whatever theme is using.
Fixes #294