ci: normalize warewulf provisioner for OpenHPC 4#48
Merged
adrianreber merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
In OpenHPC 2/3, Provisioner=warewulf means Warewulf v3 and Provisioner=warewulf4 means Warewulf v4. In OpenHPC 4, warewulf v3 is gone and Provisioner=warewulf means Warewulf v4. Normalize Provisioner to "warewulf4" when VERSION_MAJOR is 4 so that all existing warewulf4 conditionals in support_functions.sh are triggered correctly. The normalization is placed after the recipeFile path assignment to preserve the correct on-disk path (warewulf/, not warewulf4/). Generated with Claude Code (https://claude.ai/code) Signed-off-by: Adrian Reber <areber@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In OpenHPC 2/3, Provisioner=warewulf means Warewulf v3 and Provisioner=warewulf4 means Warewulf v4. In OpenHPC 4, warewulf v3 is gone and Provisioner=warewulf means Warewulf v4.
Normalize Provisioner to "warewulf4" when VERSION_MAJOR is 4 so that all existing warewulf4 conditionals in
support_functions.sh are triggered correctly. The normalization is placed after the recipeFile path assignment to preserve the correct on-disk path (warewulf/, not warewulf4/).
Generated with Claude Code (https://claude.ai/code)
CC: @middelkoopt looks simple enough