Added additional SupportedEffects and SupportedTimedEffects values

[sffubs]

My local hue hub reports these SupportedEffects and SupportedTimedEffects values. Extending these enums with these additional values avoids validation failures when using a client library built from the OpenHue API.

Summary by CodeRabbit

New Features

• Four new effects now available: underwater, cosmos, sunbeam, and enchant, expanding visual customization options
• Sunset added as a new timed effect option, extending available time-based effects

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Two YAML schema files were updated to expand their enum value sets. The SupportedEffects.yaml file gained four new effect options (underwater, cosmos, sunbeam, enchant), while SupportedTimedEffects.yaml gained one new timed effect option (sunset), broadening available selections in their respective validation schemas.

Changes

Cohort / File(s)	Summary
Schema Enum Expansions src/common/SupportedEffects.yaml	Added four new enum values: underwater, cosmos, sunbeam, enchant
Timed Effects Schema src/light/schemas/SupportedTimedEffects.yaml	Added one new enum value: sunset to the existing {sunrise, no_effect} set

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🌊✨ A rabbit hops through schemas bright,
With underwater glow and cosmic light,
Sunbeams dance and enchantments gleam,
While sunsets paint a golden dream! 🌅

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and accurately describes the main change: adding new values to SupportedEffects and SupportedTimedEffects enums, which is exactly what the changeset does.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

src/common/SupportedEffects.yaml (1)

2-13: Consider alphabetical ordering for maintainability.

The enum values could be ordered alphabetically to improve consistency and maintainability. This would make it easier to spot duplicates and find specific values.

🔎 Optional: Alphabetically ordered enum

 type: string
 enum:
-  - prism
-  - opal
-  - glisten
-  - sparkle
+  - candle
+  - cosmos
+  - enchant
   - fire
-  - candle
+  - glisten
   - no_effect
+  - opal
+  - prism
+  - sparkle
+  - sunbeam
   - underwater
-  - cosmos
-  - sunbeam
-  - enchant

src/light/schemas/SupportedTimedEffects.yaml (1)

3-6: Consider alphabetical ordering for consistency.

Similar to the other schema file, alphabetical ordering of enum values could improve maintainability.

🔎 Optional: Alphabetically ordered enum

 enum:
+  - no_effect
   - sunrise
   - sunset
-  - no_effect

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7534b8 and 3d3e241.

📒 Files selected for processing (2)

• src/common/SupportedEffects.yaml
• src/light/schemas/SupportedTimedEffects.yaml

🔇 Additional comments (1)

src/common/SupportedEffects.yaml (1)

10-13: LGTM! New effect values added correctly.

The four new effect values (underwater, cosmos, sunbeam, enchant) are officially supported in the Philips Hue API v2 (announced February 2025 under the effects_v2 feature). They follow the existing snake_case naming convention matching the legacy effects pattern, and are syntactically correct. These additions prevent validation failures in client libraries when interacting with Hue hubs that expose these effects.

[thibauult]

LGTM 👍 Thanks for your contribution!