clarify text about how encryption keys are obtained#619
Merged
Conversation
Sakurann
requested review from
GarethCOliver,
Sakurann,
awoie,
c2bo,
danielfett,
hlozi,
leecam,
martijnharing,
paulbastian and
tplooker
jogu
approved these changes
May 30, 2025
tplooker
reviewed
Jun 2, 2025
Co-authored-by: Tobias Looker <tplooker@gmail.com>
Sakurann
approved these changes
Jun 2, 2025
c2bo
approved these changes
Jun 3, 2025
awoie
reviewed
Jun 3, 2025
Contributor
awoie
left a comment
awoie
left a comment
There was a problem hiding this comment.
Generally looks fine but what is the reason the SHOULDs were removed? Is the intention to make it effectively a MUST which is ok but just wanted to clarify.
Sakurann
reviewed
Jun 3, 2025
tplooker
approved these changes
Jun 3, 2025
awoie
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hopefully fixes #616