Clarify how hashing works in transaction_data_hashes#621
Merged
Conversation
tlenz
pushed a commit
to a-sit-plus/vck
that referenced
this pull request
Jun 2, 2025
…shes
Reason: there was a discussion in openID4VP about how transaction_data_hashes
have to be calculated. Agreement to use text from v23,
see openid/OpenID4VP#621
tplooker
reviewed
Jun 2, 2025
tlenz
pushed a commit
to a-sit-plus/vck
that referenced
this pull request
Jun 3, 2025
…shes
Reason: there was a discussion in openID4VP about how transaction_data_hashes
have to be calculated. Agreement to use text from v23,
see openid/OpenID4VP#621 .
c2bo
approved these changes
Jun 3, 2025
Member
|
Also closes #615 |
tlenz
pushed a commit
to a-sit-plus/vck
that referenced
this pull request
Jun 3, 2025
…shes
Reason: there was a discussion in openID4VP about how transaction_data_hashes
have to be calculated. Agreement to use text from v23,
see openid/OpenID4VP#621
Sakurann
approved these changes
Jun 3, 2025
Collaborator
tplooker
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it clear that the hash is base64url encoded, and that the data hashed is the string that was in the request (without base64url decoding it first).
closes #457
closes #615