rename verifier_attestations parameter name to verifier_info#629
Merged
rename verifier_attestations parameter name to verifier_info#629
verifier_attestations parameter name to verifier_info#629Conversation
Sakurann
requested review from
awoie,
babisRoutis,
bc-pi,
c2bo,
cre8,
danielfett,
deshmukhrajvardhan,
jogu,
paulbastian,
tplooker and
ubamrein
paulbastian
approved these changes
Jun 5, 2025
ubamrein
approved these changes
Jun 5, 2025
c2bo
requested changes
Jun 5, 2025
Member
c2bo
left a comment
c2bo
left a comment
There was a problem hiding this comment.
We should probably also rename the section and description starting at line 672 to Verifier Info
Contributor
|
Agree with @c2bo's comment. Will approve after that comment is addressed. |
subhra-io
approved these changes
Jun 5, 2025
c2bo
approved these changes
Jun 5, 2025
deshmukhrajvardhan
approved these changes
Jun 6, 2025
cre8
approved these changes
Jun 7, 2025
Contributor
cre8
left a comment
cre8
left a comment
There was a problem hiding this comment.
By defining in the text that attestations should be passed, opening it via _info fixes the problem of similar naming.
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #613