Skip to content

fix invoice status filter #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaneck237 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix invoice status filter #60

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8acbfeb
fix invoice status filter
vaneck237 Jul 3, 2025
1e92d67
Merge branch 'develop' into feature-31983
vaneck237 Jul 7, 2025
ef45d09
fix bill filter
vaneck237 Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/InvoiceFilter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ const InvoiceFilter = ({ intl, classes, filters, onChangeFilters }) => {
withNull
nullLabel={formatMessage(intl, "invoice", "any")}
value={filterValue("status")}
onChange={onChangeStringFilter("status")}
onChange={onChangeFilter("status")}
/>
</Grid>
<Grid item xs={2} className={classes.item}>
Expand Down
16 changes: 8 additions & 8 deletions src/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ export const CONTAINS_LOOKUP = "Icontains";
export const STARTS_WITH_LOOKUP = "Istartswith";
export const ENUM_PREFIX_LENGTH = 2;
export const STATUS = {
DRAFT: "0",
VALIDATED: "1",
PAID: "2",
CANCELLED: "3",
DELETED: "4",
SUSPENDED: "5",
UNPAID: "6",
RECONCILIATED: "7",
DRAFT: "A_0",
Copy link
Member

@delcroip delcroip Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why changing that ? won't that impact payload from / to backend ?

Copy link
Author

@vaneck237 vaneck237 Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is an enum option of billStatus and invoiceStatus type in graphql
we have a bug in bill/invoice filtering with previous value

Copy link
Member

@delcroip delcroip Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I get how this helps; does GQL have A_{} options ?

Copy link
Author

@vaneck237 vaneck237 Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GQL expects type InvoiceStatus wich is an enum with the options A_{}
Screenshot 2025-11-03 at 10 14 36 AM

VALIDATED: "A_1",
PAYED: "A_2",
CANCELLED: "A_3",
DELETED: "A_4",
SUSPENDED: "A_5",
UNPAID: "A_6",
RECONCILIATED: "A_7"
};
export const SUBJECT_TYPE_OPTIONS = [
{
Expand Down
Loading