fix: prevent panic on double close of data channel in batcher #3661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add alreadyClosed flag to track if data channel was closed unexpectedly - Skip closing data channel in defer if already closed - Add unit test TestBatcher_UnexpectedChannelClose to verify the fix
buvidk1234
requested review from
FGadvancer,
skiffer-git and
withchao
as code owners
pull-request-size
bot
added
the
size/M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Re-opens PR #3654 (closed due to accidental fork deletion).
This PR fixes a panic caused by closing an already closed channel in the Batcher.
specific changes
alreadyClosedflag to track if data channel was closed unexpectedlyTestBatcher_UnexpectedChannelCloseto verify the fixFixes
Fixes #3653