Skip to content

Conversation

@asotona
Copy link
Member

@asotona asotona commented Nov 25, 2025

  • BytecodeGenerator performs proprietary lowering transformation
  • OpBuilder and tests adjusted to do not lower before calling BytecodeGenerator
  • BytecodeGenerator.ConstantLabelSwitchOp is an internal lowered representation of JavaOp.JavaSwitchOp with constant labels, and it generates tableswitch or lookupswitch instruction
  • post-processing transformations are slightly refactored

Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/706/head:pull/706
$ git checkout pull/706

Update a local copy of the PR:
$ git checkout pull/706
$ git pull https://git.openjdk.org/babylon.git pull/706/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 706

View PR using the GUI difftool:
$ git pr show -t 706

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/706.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2025

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 25, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant