8371549: [CRaC] Implement C/R in Selector on non-Linux

[rvansa]

Historically we have an extensive set of tests for java.nio.channels.Selector. However this runs only on Linux (using CRIU) rather than being platform agnostic and tested on all platforms. On Linux, it does not exercise PollSelectorImpl (this can be preferred using a system property) either - just the default EpollSelectorImpl.

This PR enables testing on all available Selector implementations, cleans up the implementation of those tests and introduces the C/R implementations.

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8371549: [CRaC] Implement C/R in Selector on non-Linux (Task - P4)

Reviewers

• Timofei Pushkin (@TimPushkin - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/276/head:pull/276
$ git checkout pull/276

Update a local copy of the PR:
$ git checkout pull/276
$ git pull https://git.openjdk.org/crac.git pull/276/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 276

View PR using the GUI difftool:
$ git pr show -t 276

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/276.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rvansa! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rvansa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371549: [CRaC] Implement C/R in Selector on non-Linux

Reviewed-by: tpushkin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the crac branch:

• af6c844: 8373784: [CRaC] VM Option to require perfect CPU fit
• 53d1ac4: 8374491: CPUFeatures: check performance regression of AVX_Fast_Unaligned_Load
• abf0868: 8373781: [CRaC] Permit -XX:CPUFeatures on other platforms
• ... and 4 more: https://git.openjdk.org/crac/compare/01229e606e0fc307db11e1fc5f6fc196265eba77...crac

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the crac branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 05: Full - Incremental (c6e6799f)
• 04: Full - Incremental (1ec7201c)
• 03: Full - Incremental (a1629ffe)
• 02: Full - Incremental (e90eac79)
• 01: Full - Incremental (8fff09d5)
• 00: Full (69fead7d)

[TimPushkin]

Sorry, the change is big and I haven't had enough spare time to review it recently. Hopefully will get to it in upcoming weeks, if nobody else will. I believe this is not a priority and does not block anything?

[rvansa]

@TimPushkin I think we had it pop somewhere but it's not a high priority. Ideally if you can review in early January.

[TimPushkin]

I haven't read through SelectorCRaCSupport very carefully since it's mainly pre-existing code

[rvansa]

Failure in JdwpTransportTest is unrelated.

[rvansa]

/integrate

[openjdk]

Going to push as commit 4b84ed3.
Since your change was applied there have been 7 commits pushed to the crac branch:

• af6c844: 8373784: [CRaC] VM Option to require perfect CPU fit
• 53d1ac4: 8374491: CPUFeatures: check performance regression of AVX_Fast_Unaligned_Load
• abf0868: 8373781: [CRaC] Permit -XX:CPUFeatures on other platforms
• ... and 4 more: https://git.openjdk.org/crac/compare/01229e606e0fc307db11e1fc5f6fc196265eba77...crac

Your commit was automatically rebased without conflicts.

[openjdk]

@rvansa Pushed as commit 4b84ed3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.