-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8359955: Regressions ~7% in several J2DBench in 25-b26 #26702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back dgredler! A progress list of the required criteria for merging this PR into |
@gredler This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 171 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I ran all our automated jtreg tests on all platforms, plus JCK.
Addresses recent slight performance regressions in some J2DBench benchmarks focused on text drawing.
CCharToGlyphMapper
andCompositeGlyphMapper
cache glyph IDs, but after JDK-8353230 they weren't caching glyph IDs for chars which might be affected by the raw / non-raw glyph distinction, since the cached value may not be correct if we ask for a raw glyph ID one time, but a non-raw glyph ID the next time (or vice versa). This caching exception was the reason for the slightly degraded performance (theCCharToGlyphMapper
behavior was affecting macOS, and theCompositeGlyphMapper
behavior was affecting some versions of Windows). This change splits the cache in each of these two classes into two caches, one for raw glyph IDs and one for non-raw glyph IDs, so that all glyphs can benefit from caching.All of the font tests (
make test TEST="jtreg:test/jdk/java/awt/font"
) pass for me locally with this change on Linux, macOS and Windows.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26702/head:pull/26702
$ git checkout pull/26702
Update a local copy of the PR:
$ git checkout pull/26702
$ git pull https://git.openjdk.org/jdk.git pull/26702/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26702
View PR using the GUI difftool:
$ git pr show -t 26702
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26702.diff
Using Webrev
Link to Webrev Comment