Skip to content

8364761: (aio) AsynchronousChannelGroup.execute doesn't check null command #26709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bplb
Copy link
Member

@bplb bplb commented Aug 9, 2025

Add null check to AsynchronousChannelGroupImpl.execute; update existing test.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8364761: (aio) AsynchronousChannelGroup.execute doesn't check null command (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26709/head:pull/26709
$ git checkout pull/26709

Update a local copy of the PR:
$ git checkout pull/26709
$ git pull https://git.openjdk.org/jdk.git pull/26709/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26709

View PR using the GUI difftool:
$ git pr show -t 26709

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26709.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2025

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 9, 2025

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364761: (aio) AsynchronousChannelGroup.execute doesn't check null command

Reviewed-by: alanb, vyazici

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Aug 9, 2025

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added nio [email protected] rfr Pull request is ready for review labels Aug 9, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 9, 2025

Webrevs

Copy link
Contributor

@vy vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 11, 2025
@bplb
Copy link
Member Author

bplb commented Aug 11, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Aug 11, 2025

Going to push as commit 8cd7975.
Since your change was applied there have been 20 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 11, 2025
@openjdk openjdk bot closed this Aug 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 11, 2025
@openjdk
Copy link

openjdk bot commented Aug 11, 2025

@bplb Pushed as commit 8cd7975.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the AsynchronousChannelGroupImpl-execute-8364761 branch August 11, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio [email protected]
Development

Successfully merging this pull request may close these issues.

3 participants