-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8365184: sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java Re-enable SerialGC flag on debuggee process #26711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back rsunderbabu! A progress list of the required criteria for merging this PR into |
@rsunderbabu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 34 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lmesnik, @plummercj, @sspitsyn) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@rsunderbabu The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
… SerialGC flag on debuggee process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. BTW, you could have still used the old PR and just changed the title to reflect the new CR.
/integrate |
@rsunderbabu |
/label remove core-libs |
@AlanBateman |
VM argument UseSerialGC was not allowed while launching the debuggee process due to classloader related issue (JDK-8313655). During the effort to improve the test's handling of the issue, it was observed that SerialGC doesn't cause any issue any more. This could possibly due to improved handling of ClassLoaderData or SerialGC.
After extensively testing the argument in various platforms and for many iterations, it was decided to allow the argument here on.
Testing: Tiers1,2,3 and other ties where the test runs.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26711/head:pull/26711
$ git checkout pull/26711
Update a local copy of the PR:
$ git checkout pull/26711
$ git pull https://git.openjdk.org/jdk.git pull/26711/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26711
View PR using the GUI difftool:
$ git pr show -t 26711
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26711.diff
Using Webrev
Link to Webrev Comment