Skip to content

8364751: ConstantBootstraps.explicitCast contradictory specification for null-to-primitive #26714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

liach
Copy link
Member

@liach liach commented Aug 10, 2025

ConstantBootstraps.explicitCast behaves like a snippet of code in its specification. However, in the rest of the nominal spec, it incorrectly assumes a null value and a primitive dstType results in a ClassCastException instead of the zero value of that primitive type. This is inconsistent with that snippet and the actual code behavior.

The specification is fixed, the test for explicitCast is merged into the main ConstantBootstraps test, and a new unit test case for value = null and dstType = char.class is added, verifying the outcome is 'u0000'.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8365193 to be approved

Issues

  • JDK-8364751: ConstantBootstraps.explicitCast contradictory specification for null-to-primitive (Bug - P4)
  • JDK-8365193: ConstantBootstraps.explicitCast contradictory specification for null-to-primitive (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26714/head:pull/26714
$ git checkout pull/26714

Update a local copy of the PR:
$ git checkout pull/26714
$ git pull https://git.openjdk.org/jdk.git pull/26714/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26714

View PR using the GUI difftool:
$ git pr show -t 26714

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26714.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 10, 2025

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Aug 10, 2025
@openjdk
Copy link

openjdk bot commented Aug 10, 2025

@liach The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs [email protected] rfr Pull request is ready for review labels Aug 10, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 10, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant