8364751: ConstantBootstraps.explicitCast contradictory specification for null-to-primitive #26714
+52
−88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConstantBootstraps.explicitCast behaves like a snippet of code in its specification. However, in the rest of the nominal spec, it incorrectly assumes a null
value
and a primitivedstType
results in a ClassCastException instead of the zero value of that primitive type. This is inconsistent with that snippet and the actual code behavior.The specification is fixed, the test for
explicitCast
is merged into the mainConstantBootstraps
test, and a new unit test case forvalue = null
anddstType = char.class
is added, verifying the outcome is'u0000'
.Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26714/head:pull/26714
$ git checkout pull/26714
Update a local copy of the PR:
$ git checkout pull/26714
$ git pull https://git.openjdk.org/jdk.git pull/26714/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26714
View PR using the GUI difftool:
$ git pr show -t 26714
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26714.diff
Using Webrev
Link to Webrev Comment