8365231: Don't build gtest with /EHsc #26721
Open
+2
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #26661 (comment), we should not build gtest with
/EHsc
.I can honestly say I don't fully understand the consequences of this change, but at least it passes building and testing on Oracle CI. And it does seem to make sense that we build the gtest version of libjvm as close as possible to the real version. For libgtest I just thought it was prudent to keep the flags in sync with how we build libjvm. This might not be the correct decision.
I have not tested how or if this affects the ability for gtest to handle bugs or crashes in the JVM, nor do I really have any idea about any such consequences. This PR is opened more to start a discussion than with the intention of just integrating this.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26721/head:pull/26721
$ git checkout pull/26721
Update a local copy of the PR:
$ git checkout pull/26721
$ git pull https://git.openjdk.org/jdk.git pull/26721/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26721
View PR using the GUI difftool:
$ git pr show -t 26721
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26721.diff
Using Webrev
Link to Webrev Comment