8365937: post_method_exit might incorrectly set was_popped_by_exception and value in the middle of stack unwinding

[lmesnik]

The void JvmtiExport::post_method_exit(JavaThread* thread, Method* method, frame current_frame) calculates
bool exception_exit = state->is_exception_detected() && !state->is_exception_caught();
to find if method exit normally or by exception.
However, JvmtiExport::post_method_exit( method is not called at all in the case of exception. See
void JvmtiExport::notice_unwind_due_to_exception(JavaThread *thread, Method* method, address location, oop exception, bool in_handler_frame)
where post_method_exit_inner is called directly.

The exception_exit is true when exception is processed and the current method is called in the middle of stack unwinding.

The fix was a part of
#26713
for
https://bugs.openjdk.org/browse/JDK-8365192

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365937: post_method_exit might incorrectly set was_popped_by_exception and value in the middle of stack unwinding (Bug - P4)

Reviewers

• Patricio Chilano Mateo (@pchilano - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26886/head:pull/26886
$ git checkout pull/26886

Update a local copy of the PR:
$ git checkout pull/26886
$ git pull https://git.openjdk.org/jdk.git pull/26886/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26886

View PR using the GUI difftool:
$ git pr show -t 26886

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26886.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365937: post_method_exit might incorrectly set was_popped_by_exception and value in the middle of stack unwinding

Reviewed-by: pchilanomate

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 166 new commits pushed to the master branch:

• a40afdd: 8366537: Test "java/util/TimeZone/DefaultTimeZoneTest.java" is not updating the zone ID as expected
• d5935af: 8366768: Problemlist jdk/jshell/ToolSimpleTest.java
• 3abaa83: 8366298: FDLeakTest sometimes takes minutes to complete on Linux
• ... and 163 more: https://git.openjdk.org/jdk/compare/cf70cb70bcd5292ed10d8fb08019f0da82db25dd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lmesnik The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (09607978)
• 02: Full - Incremental (4e05639a)
• 01: Full - Incremental (d9319d90)
• 00: Full (e8343e08)

[dholmes-ora]

Looks good. A few style nits and a couple of suggestions.

This will make the other PR much easier to review.

Thanks

[pchilano]

LGTM. Thanks for fixing and adding the extra tests.