Skip to content

Conversation

dev-jonghoonpark
Copy link
Contributor

@dev-jonghoonpark dev-jonghoonpark commented Oct 5, 2025

related jira issue: https://bugs.openjdk.org/browse/JDK-8365782


Changes

As described in the issue, I have removed the unnecessary inclusion of stdlib.h.

This was first discussed in this comment.

As noted in the discussion, generate_environment_variables_events also appears to be unimplemented, so it has been removed as well.


Verification

  • Checked that no functions from stdlib.h are called in the file.
  • Checked that the generate_environment_variables_events function is not implemented anywhere in the codebase.
  • Ran the tier1 tests after the changes and confirmed that there were no issues.

Please let me know if there are any additional or more appropriate verification steps I should perform.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365782: Remove unnecessary inclusion of <stdlib.h> in jfrOSInterface.cpp (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27639/head:pull/27639
$ git checkout pull/27639

Update a local copy of the PR:
$ git checkout pull/27639
$ git pull https://git.openjdk.org/jdk.git pull/27639/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27639

View PR using the GUI difftool:
$ git pr show -t 27639

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27639.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2025

👋 Welcome back dev-jonghoonpark! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 5, 2025

@dev-jonghoonpark This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365782: Remove unnecessary inclusion of <stdlib.h> in jfrOSInterface.cpp

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@albertnetymk, @tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Oct 5, 2025

@dev-jonghoonpark The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 5, 2025
@dev-jonghoonpark dev-jonghoonpark changed the title 8365782: cleanup: Remove unnecessary inclusion of <stdlib.h> in jfrOSInterface.cpp 8365782: Remove unnecessary inclusion of <stdlib.h> in jfrOSInterface.cpp Oct 5, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 5, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 6, 2025
@dev-jonghoonpark
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 6, 2025
@openjdk
Copy link

openjdk bot commented Oct 6, 2025

@dev-jonghoonpark
Your change (at version 9687a4b) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored
Development

Successfully merging this pull request may close these issues.

3 participants