8368500: ContextClassLoader cannot be reset on threads in ForkJoinPool.commonPool() #27648
Conversation
|
👋 Welcome back johnyjose30! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@johnyjose30 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
|
||
| @Test | ||
| void testContextClassLoaderIsSetAndRestored() throws InterruptedException { | ||
| CountDownLatch latch = new CountDownLatch(1); |
There was a problem hiding this comment.
It looks like latch.await() is missing from the test.
| if (customCCL instanceof URLClassLoader) { | ||
| ((URLClassLoader) customCCL).close(); | ||
| } | ||
| } catch (Exception ignored) {} |
There was a problem hiding this comment.
You can remove the customCCL.close, there are no JAR/other resources to close.
The permanent disabling of the Security Manager in JDK 24 allow setCCL to set the CCL to a custom class loader. However, it doesn't allow it to be set to a custom class loader and then "reset" back to the system class loader before executing further code in the task. The changes are made to relax the restriction in setCCL to reset back to system class loader
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27648/head:pull/27648$ git checkout pull/27648Update a local copy of the PR:
$ git checkout pull/27648$ git pull https://git.openjdk.org/jdk.git pull/27648/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27648View PR using the GUI difftool:
$ git pr show -t 27648Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27648.diff
Using Webrev
Link to Webrev Comment