Skip to content

Conversation

theRealAph
Copy link
Contributor

@theRealAph theRealAph commented Oct 6, 2025

RelocActions is instantiated every time we need to apply a reloc. There's really no need for this, and the use of virtual member functions and function pointers obfuscates the code.

While C++ compilers can devirtualize much of this, they don't always devirtualize all of it. Let's make RelocActions all static.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8369211: AArch64: Devirtualize class RelocActions (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27649/head:pull/27649
$ git checkout pull/27649

Update a local copy of the PR:
$ git checkout pull/27649
$ git pull https://git.openjdk.org/jdk.git pull/27649/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27649

View PR using the GUI difftool:
$ git pr show -t 27649

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27649.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2025

👋 Welcome back aph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 6, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 6, 2025

@theRealAph The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@theRealAph theRealAph changed the title AArch64: Devirtualize class RelocActions 8369211: AArch64: Devirtualize class RelocActions Oct 6, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 6, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 6, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant