7105350: HttpExchange's attributes are the same as HttpContext's attributes #27652
Conversation
|
👋 Welcome back SentryMan! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@SentryMan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
| private static final boolean perExchangeAttributes = | ||
| !System.getProperty("jdk.httpserver.attributes", "") | ||
| .equals("context"); |
There was a problem hiding this comment.
The property will have to be documented somewhere such as the jdk.httpserver module-info. But, I'm wondering if fairly obscure properties like this might be better off "buried" in the net.properties config file. I think there's a case for putting all such "compatibility" flags somewhere out of the way like that. If we were to do that, you would need to access the property using sun.net.NetProperties.
Any other views on this?
| throw new NullPointerException("null name parameter"); | ||
| } | ||
| if (attributes == null) { | ||
| attributes = getHttpContext().getAttributes(); | ||
| } | ||
| return attributes.get (name); | ||
| return attributes.get(name); |
There was a problem hiding this comment.
Consider replacing this with Objects.requireNonNull
| } | ||
| if (attributes == null) { | ||
| attributes = getHttpContext().getAttributes(); | ||
| throw new NullPointerException("null name parameter"); |
Now ExchangeImpl will default to having a separate attribute map for the request duration.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27652/head:pull/27652$ git checkout pull/27652Update a local copy of the PR:
$ git checkout pull/27652$ git pull https://git.openjdk.org/jdk.git pull/27652/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27652View PR using the GUI difftool:
$ git pr show -t 27652Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27652.diff
Using Webrev
Link to Webrev Comment