-
Notifications
You must be signed in to change notification settings - Fork 6.3k
8362598: [macos] Add tests for custom info plist files #27658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8362598: [macos] Add tests for custom info plist files #27658
Conversation
…t and converts it into a string property map; added writeFaPListFragment() that takes JPackageCommand instance and outputs expected file associations portion of the app bundle Info.plist file; fix getPackageId(); add unite tests for MacHelper.flatMapPList()
…eption into RuntimeException, not into IOException
…Helper api; improve coverage
👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@alexeysemenyukoracle The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Enhancement of #27509 PR
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27658/head:pull/27658
$ git checkout pull/27658
Update a local copy of the PR:
$ git checkout pull/27658
$ git pull https://git.openjdk.org/jdk.git pull/27658/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27658
View PR using the GUI difftool:
$ git pr show -t 27658
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27658.diff