8369184: SimpleTimeZone equals() Returns True for Unequal Instances with Different hashCode Values #27660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the equals/hashCode contract in the SimpleTimeZone class. The current implementation includes DST rule fields in hash code computation even for zones that do not observe DST, while equals() always considers them. Also correcting the example code in the class description, where it used 20-year-old obsolete "America/Los_Angeles" rule.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27660/head:pull/27660
$ git checkout pull/27660
Update a local copy of the PR:
$ git checkout pull/27660
$ git pull https://git.openjdk.org/jdk.git pull/27660/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27660
View PR using the GUI difftool:
$ git pr show -t 27660
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27660.diff
Using Webrev
Link to Webrev Comment