8372266: Relax store matchers in compiler/escapeAnalysis/TestRematerializeObjects.java test

[shipilev]

As you can see in the report, current matchers rely heavily on mainline C2 implementation to match specific stores. This fails when we try to backport MergeStores fixes to 25u. It would be better to relax the matchers a bit to cater for 25u backports, and also making test more robust for future MergeStores changes, if any.

Additional testing:

• Linux x86_64 server fastdebug, mainline, affected test, 100x
• Linux AArch64 server fastdebug, mainline, affected test, 100x
• Linux x86_64 server fastdebug, jdk25u, affected test, 100x

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372266: Relax store matchers in compiler/escapeAnalysis/TestRematerializeObjects.java test (Bug - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28437/head:pull/28437
$ git checkout pull/28437

Update a local copy of the PR:
$ git checkout pull/28437
$ git pull https://git.openjdk.org/jdk.git pull/28437/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28437

View PR using the GUI difftool:
$ git pr show -t 28437

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28437.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372266: Relax store matchers in compiler/escapeAnalysis/TestRematerializeObjects.java test

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• ee9d553: 8372307: Clean up the leftover code comment references to file.encoding in java_props_md.c
• 2d815ac: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test
• 2b5cd14: 8282441: [LOOM] The debug agent should attempt to free vthread ThreadNodes
• ... and 40 more: https://git.openjdk.org/jdk/compare/852141b9d42ada168a008aea63045deddca29190...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (83eb5c1f)

[shipilev]

/touch

Hey bots, figure out the issue exists.

[openjdk]

@shipilev The pull request is being re-evaluated and the inactivity timeout has been reset.

[vnkozlov]

Looks good to me. I submitted testing.

[vnkozlov]

@eme64 please look on this too.

[vnkozlov]

My testing passed.