Skip to content

Conversation

@vpa1977
Copy link
Contributor

@vpa1977 vpa1977 commented Nov 21, 2025

JFR stubs are not implemented.
Add platform requirement to JFR tests that require JFR stubs to skip them on S390x.

Testing:

  • s390x:
==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR  SKIP   
   jtreg:test/hotspot/jtreg/applications/ctw/modules/jdk_jfr.java
                                                         0     0     0     0     0   
   jtreg:test/hotspot/jtreg/compiler/intrinsics/TestReturnOopSetForJFRWriteCheckpoint.java
                                                         0     0     0     0     0   
   jtreg:test/jdk/jdk/jfr                              630   577     0     0    53   
==============================
TEST SUCCESS
  • amd64:
==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR  SKIP   
   jtreg:test/hotspot/jtreg/applications/ctw/modules/jdk_jfr.java
                                                         1     1     0     0     0   
   jtreg:test/hotspot/jtreg/compiler/intrinsics/TestReturnOopSetForJFRWriteCheckpoint.java
                                                         1     1     0     0     0   
   jtreg:test/jdk/jdk/jfr                              629   622     0     0     7   
==============================
TEST SUCCESS

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352567: [s390x] disable JFR tests requiring JFR stubs (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28444/head:pull/28444
$ git checkout pull/28444

Update a local copy of the PR:
$ git checkout pull/28444
$ git pull https://git.openjdk.org/jdk.git pull/28444/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28444

View PR using the GUI difftool:
$ git pr show -t 28444

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28444.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2025

👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@vpa1977 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@vpa1977 vpa1977 marked this pull request as ready for review November 21, 2025 05:22
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 21, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant