Skip to content

Conversation

@eme64
Copy link
Contributor

@eme64 eme64 commented Nov 21, 2025

TODO

make sure failures are logged more clearly, under SW_REJECTIONS

During SuperWord, we want to insert the aliasing runtime check above 687 ParsePredicate which is annotated with #Auto_Vectorization_Check. For this, we require the pre_init value: 1244 AddI. Sadly, this value is pinned lower down.
image

So when we insert the aliasing runtime check, we create a bad (circular) graph:
image


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371146: C2 SuperWord: VTransform::add_speculative_check uses pre_init that is pinned after Auto_Vectorization_Check, leading to bad graph (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28449/head:pull/28449
$ git checkout pull/28449

Update a local copy of the PR:
$ git checkout pull/28449
$ git pull https://git.openjdk.org/jdk.git pull/28449/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28449

View PR using the GUI difftool:
$ git pr show -t 28449

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28449.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2025

👋 Welcome back epeter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8371146 8371146: C2 SuperWord: VTransform::add_speculative_check uses pre_init that is pinned after Auto_Vectorization_Check, leading to bad graph Nov 21, 2025
@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@eme64 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant