8372256 : ClassCastException in ConcurrentHashMap#equals

[viktorklang-ora]

Adding logic to handle CCEs and NPEs (the latter cannot logically occur as CHM does not support null keys) as per AbstractMap::equals

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372256: ClassCastException in ConcurrentHashMap#equals (Bug - P4)

Reviewers

• Doug Lea (@DougLea - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28453/head:pull/28453
$ git checkout pull/28453

Update a local copy of the PR:
$ git checkout pull/28453
$ git pull https://git.openjdk.org/jdk.git pull/28453/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28453

View PR using the GUI difftool:
$ git pr show -t 28453

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28453.diff

Using Webrev

Link to Webrev Comment

[viktorklang-ora]

Tagging @DougLea & @AlanBateman

[bridgekeeper]

👋 Welcome back vklang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@viktorklang-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372256: ClassCastException in `ConcurrentHashMap#equals`

Reviewed-by: dl, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

• e4b583a: 8372294: Fix Malformed problem list entry in ProblemList-jvmti-stress-agent.txt
• e24e782: 8372319: com/sun/crypto/provider/Cipher/HPKE/KAT9180 test has external dependencies
• 5f806e7: 8367049: URLPermission. throws StringIndexOutOfBoundsException in avm mode
• ... and 54 more: https://git.openjdk.org/jdk/compare/99135d2e05bb501fe9f9f0d36abd25894d0f93de...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@viktorklang-ora The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7ea9a9e8)

[DougLea]

Looks good. Thanks for doing this!

[AlanBateman]

Okay although another random usage of get(Object) with an key for the wrong type will also fail with CCE.