Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 21, 2025

There is some UL output in the string deduplication code that is not very clear and has room for improvement.
The inspected strings number should be shown and the new unknown strings get a changed text.
(also the new JFR strip dedup event description is slightly adjusted)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372348: Adjust some UL / JFR string deduplication output messages (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28455/head:pull/28455
$ git checkout pull/28455

Update a local copy of the PR:
$ git checkout pull/28455
$ git pull https://git.openjdk.org/jdk.git pull/28455/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28455

View PR using the GUI difftool:
$ git pr show -t 28455

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28455.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8372348: Adjust some UL / JFR string deduplication output messages 8372348: Adjust some UL / JFR string deduplication output messages Nov 21, 2025
@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 21, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant