8350938: ResourceParsingClassHierarchyResolver inflates all Utf8 CP entries #28458
+9
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance
ResourceParsingClassHierarchyResolver.getClassInfoto useClassReaderImplto improve performance. Previously this method inflated and stored all UTF-8 entries in the constant pool and later accessed the array of strings to try finding the name of the superclass.ClassReaderImplinstead stores constant pool offsets and later lazily reads/inflates UTF8 entries as needed.I’ve ran all tier 1 tests and tests within
test/jdk/jdk/classfileon the latest version of this change, and they all pass.I ran some informal performance testing to see if these changes led to any improvement. I created a .class file with several thousand unique strings in a String array to deliberately enlarge the number of UTF-8 entries in the constant pool. I then benchmarked the performance of running a process nearly identical to
ClassHierarchyInfoTest.testClassLoaderParsingResolveron this custom class over 200 runs using JMH. The results are as follows.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28458/head:pull/28458$ git checkout pull/28458Update a local copy of the PR:
$ git checkout pull/28458$ git pull https://git.openjdk.org/jdk.git pull/28458/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28458View PR using the GUI difftool:
$ git pr show -t 28458Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28458.diff
Using Webrev
Link to Webrev Comment