8374796: CompressedOops versions of runtime/cds/TestDefaultArchiveLoading.java aren't run

[coleenp]

This simple change from

@requires !vm.gc.Z
to
@requires vm.gc != "Z"

Makes the two coops version of this test run and not get:
Test results: passed: 2; did not meet platform requirements: 2

Neither of these enables the test to run.
@requires vm.gc.Z == false
or
@requires vm.opt.final.UseZGC == false

This could be a bug in jtreg-ext/requires/VMProps.java support but I was unable to find that.

Tested with the test.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8374796: CompressedOops versions of runtime/cds/TestDefaultArchiveLoading.java aren't run (Bug - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29125/head:pull/29125
$ git checkout pull/29125

Update a local copy of the PR:
$ git checkout pull/29125
$ git pull https://git.openjdk.org/jdk.git pull/29125/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29125

View PR using the GUI difftool:
$ git pr show -t 29125

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29125.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374796: CompressedOops versions of runtime/cds/TestDefaultArchiveLoading.java aren't run

Reviewed-by: stefank, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 67 new commits pushed to the master branch:

• c8c6e70: 8374825: vmTestbase comment typo: lunch
• 2a965df: 8374377: PNGImageDecoder Slow For 8-bit PNGs
• a855224: 8373695: G1: Using a value near integer max for ActiveProcessorCount causes fatal crash
• ... and 64 more: https://git.openjdk.org/jdk/compare/de81d38995356a2e8528a419ebd445e79cd136d1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4aaac30b)

[stefank]

Looks good and trivial.

[shipilev]

This could be a bug in jtreg-ext/requires/VMProps.java support but I was unable to find that.

Not a bug, it is a complicated behavior of these properties. Everyone falls into this trap every so often. Perhaps we should think to rename these properties so they are not as confusing.

vm.gc.Z means "Current VM potentially supports ZGC, so you can opt into it later with -XX:+UseZGC". So !vm.gc.Z effectively says "only run these tests if ZGC is not available in VM, e.g. by disabled build feature flag". Which means the subtests are disabled pretty much everywhere.

vm.gc == "Z" means "Current VM supports ZGC and has it currently enabled (e.g. with -XX:+UseZGC, e.g. with additional VM test options)". So vm.gc != "Z" says "This test should not be executed if ZGC is enabled, e.g. by some testing profile". Which I believe is the original intent of this @requires.

[shipilev]

Looks to be a regression from JDK-8365932, where Erik fell into this trap this time around :) Pull this fix into JDK 26 as well, please.

[shipilev]

GHA build failure on Linux x86_64 fastdebug likely caused by infra issues. I fixed some this week. Merge from current master if you want to see clean GHA run.

[coleenp]

Thanks for reviewing Stefan and Aleksey, and thanks for explaining the GHA failure. It seemed like an infra issue.
I'd have to upgrade this bug to backport to JDK 26, but I can do that.
/integrate

[openjdk]

Going to push as commit 6d1bfdf.
Since your change was applied there have been 68 commits pushed to the master branch:

• 47e1935: 8373941: Epsilon: Robust counter updates in early VM phases
• c8c6e70: 8374825: vmTestbase comment typo: lunch
• 2a965df: 8374377: PNGImageDecoder Slow For 8-bit PNGs
• ... and 65 more: https://git.openjdk.org/jdk/compare/de81d38995356a2e8528a419ebd445e79cd136d1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 6d1bfdf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[coleenp]

/backport jdk26

[openjdk]

@coleenp The target repository jdk26 is not a valid target for backports.
List of valid target repositories: openjdk/jdk, openjdk/jdk11u, openjdk/jdk11u-dev, openjdk/jdk17u, openjdk/jdk17u-dev, openjdk/jdk21u, openjdk/jdk21u-dev, openjdk/jdk25u, openjdk/jdk25u-dev, openjdk/jdk26u, openjdk/jdk8u, openjdk/jdk8u-dev, openjdk/jfx, openjdk/jfx17u, openjdk/jfx21u, openjdk/jfx25u, openjdk/lilliput-jdk17u, openjdk/lilliput-jdk21u, openjdk/lilliput-jdk25u, openjdk/shenandoah-jdk21u, openjdk/shenandoah-jdk8u.
Supplying the organization/group prefix is optional.

There is a branch jdk26 in the current repository openjdk/jdk.
To target a backport to this branch in the current repository use:
/backport :jdk26

[coleenp]

/backport :jdk26

[openjdk]

@coleenp the backport was successfully created on the branch backport-coleenp-6d1bfdf7-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6d1bfdf7 from the openjdk/jdk repository.

The commit being backported was authored by Coleen Phillimore on 9 Jan 2026 and was reviewed by Stefan Karlsson and Aleksey Shipilev.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-coleenp-6d1bfdf7-jdk26:backport-coleenp-6d1bfdf7-jdk26
$ git checkout backport-coleenp-6d1bfdf7-jdk26
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-coleenp-6d1bfdf7-jdk26