8355249: Remove the use of WMIC from the entire source code

[kurashige23]

Hi all,

This is a backport of JDK-8355249 : Remove the use of WMIC from the entire source code

JDK-8355249 is an enhancement, but the future removal of WMIC will affect any version of jdk, so I think it needs to be backported.

Original patch does not apply cleanly because WindowsHelper.java doesn't exist in jdk11. WindowsHelper.java was added in jdk14 (JDK-8212780). Except for this point, original patch applies cleanly.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8355249 needs maintainer approval

Issue

• JDK-8355249: Remove the use of WMIC from the entire source code (Enhancement - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3057/head:pull/3057
$ git checkout pull/3057

Update a local copy of the PR:
$ git checkout pull/3057
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3057/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3057

View PR using the GUI difftool:
$ git pr show -t 3057

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3057.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tkurashige! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kurashige23 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8355249: Remove the use of WMIC from the entire source code

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 098d324: 8231943: ZGC: Enable serviceability/dcmd/gc/RunGCTest
• 694f561: 8247362: HeapDumpCompressedTest.java#id0 fails due to "Multiple garbage collectors selected"
• a7e7709: 8340185: Use make -k on GHA to catch more build errors
• ... and 13 more: https://git.openjdk.org/jdk11u-dev/compare/646b6b5ed967de67ebf90592eadf08c749c7e364...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (d14c60d3)

[openjdk]

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[kurashige23]

/approval request Backporting this protects against the risk of future removal of WMIC.
Original patch does not apply cleanly because WindowsHelper.java doesn't exist in jdk11.
This fix constists of makefile fix and test fix, low risk.

[openjdk]

@kurashige23
8355249: The approval request has been created successfully.

[kurashige23]

Thank you for your review.

/integrate

[openjdk]

@kurashige23
Your change (at version d14c60d) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit d2a17d1.
Since your change was applied there have been 21 commits pushed to the master branch:

• 5b0c280: 8343618: Stack smashing in awt_InputMethod.c on Linux s390x
• 5aa91df: 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings
• 0e8228d: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests
• ... and 18 more: https://git.openjdk.org/jdk11u-dev/compare/646b6b5ed967de67ebf90592eadf08c749c7e364...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @kurashige23 Pushed as commit d2a17d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.