-
Notifications
You must be signed in to change notification settings - Fork 243
8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs #3064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean backport from 17u net of deleted line formatting.
|
Taking a closer look at the history, seeing this commit when initially backporting the test. Planning to adjust to not use |
Backporting JDK-8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs. Adjusting test to be compatible with GCs other than G1. Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test directly. Patch is nearly clean: since
Reference.refersTo
is not supported, needs minor adjustments.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3064/head:pull/3064
$ git checkout pull/3064
Update a local copy of the PR:
$ git checkout pull/3064
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3064/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3064
View PR using the GUI difftool:
$ git pr show -t 3064
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3064.diff
Using Webrev
Link to Webrev Comment